Soft error whisper.#22475
Merged
Merged
Conversation
|
The documentation is not available anymore as the PR was closed or merged. |
ArthurZucker
approved these changes
Mar 30, 2023
ArthurZucker
left a comment
ArthurZucker
left a comment
Collaborator
There was a problem hiding this comment.
Great! Thanks for this fix
Comment on lines
881
to
883
| "There was an error while processing timestamps, we haven't found a timestamp as last token. Was" | ||
| " WhisperTimeStampLogitsProcessor used?" | ||
| ) |
Collaborator
There was a problem hiding this comment.
Since you suspect that the model was probably not finetuned with timestamps we can also add this
Contributor
Author
There was a problem hiding this comment.
I hesitated to put it here. While I have 1 example where I think it's true, I don't think it's enough to make it the first and foremost recommendation.
Contributor
There was a problem hiding this comment.
(I occasionally hit this error when using the pre-trained model in Flax, so it's not specific to fine-tuned ones!)
Contributor
Author
There was a problem hiding this comment.
Interesting to know !
raghavanone
pushed a commit
to raghavanone/transformers
that referenced
this pull request
Apr 5, 2023
* Soft error whisper. * Fix format. --------- Co-authored-by: Ubuntu <ubuntu@ip-172-31-34-94.taildb5d.ts.net>
novice03
pushed a commit
to novice03/transformers
that referenced
this pull request
Jun 23, 2023
* Soft error whisper. * Fix format. --------- Co-authored-by: Ubuntu <ubuntu@ip-172-31-34-94.taildb5d.ts.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Moving the hard error on whisper timestamp to a soft error.
Results are definitely odd potentially non sensical, but at least we're not hard errorring out.
Fixes # (issue)
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Fix #22053 #22053
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.